Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: moving internal StreamingProcessor class from js-sdk-common to js-server-sdk-common #700

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

tanderson-ld
Copy link
Contributor

@tanderson-ld tanderson-ld commented Dec 2, 2024

Requirements

  • I have added test coverage for new or changed functionality
    No behavioral changes, existing tests migrated with class.

  • I have followed the repository's pull request submission guidelines

  • I have validated my changes against all supported platform versions

Related issues

SDK-156, prepping for SDK-849

Copy link
Contributor

github-actions bot commented Dec 2, 2024

@launchdarkly/js-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 17781 bytes
Size limit: 21000

Copy link
Contributor

github-actions bot commented Dec 2, 2024

@launchdarkly/js-client-sdk size report
This is the brotli compressed size of the ESM build.
Size: 19209 bytes
Size limit: 21000

@tanderson-ld tanderson-ld changed the title chore: moving internal StreamingProcessor class from js-sdk-common to js-server-sdk-common chore: moving internal StreamingProcessor class from js-sdk-common to js-server-sdk-common Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

@launchdarkly/js-client-sdk-common size report
This is the brotli compressed size of the ESM build.
Size: 15354 bytes
Size limit: 20000

@tanderson-ld tanderson-ld marked this pull request as ready for review December 2, 2024 21:19
@tanderson-ld tanderson-ld requested a review from a team as a code owner December 2, 2024 21:19
@tanderson-ld tanderson-ld merged commit 7266baa into main Dec 4, 2024
24 checks passed
@tanderson-ld tanderson-ld deleted the ta/sdk-156/move-streamingprocessor-out-of-common branch December 4, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants